update dcr optimization error messages #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jatakiajanvi12
previously approved these changes
Apr 16, 2024
ganga1980
reviewed
Apr 16, 2024
ganga1980
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to the error messages in the
dcr-config-parser.rbscript. The changes make the error messages more informative, providing additional context for troubleshooting. Specifically, the error message for when no JSON file is found now suggests checking if mdsd is running in MSI mode. Similarly, the error message for when the required key 'dataSources' is missing from the JSON structure now suggests checking if DCR is valid.