New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed optimizer problem for classifer, enabled both batch_first args #173

Closed

adityakusupati wants to merge 2 commits into microsoft:master from adityakusupati:master

Contributor

adityakusupati commented Apr 30, 2020

@SachinG007 @harsha-simhadri this PR fixes more issues of compatibility and correctness for end-to-end fastcell_example.py

adityakusupati added 2 commits

April 30, 2020 01:40


          Fixed optimizer problem for classifer, enabled both batch_first=True …

ac6b231

…and False for the example


          fixed return of feats from computeLogits

65933a6

adityakusupati mentioned this pull request

FastCell Example Fixes, Generalized trainer for both batch_first args #174

Open

Contributor Author

adityakusupati commented May 7, 2020

Will fix #174 to incorporate this PR.

adityakusupati closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment