-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving modularity in EMI-RNN Implementation #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rators: restoring untested
Closed
Scripts for downloading HAR dataset and organising it into train-val-test files
metastableB
changed the title
[WIP] Improving modularity in EMI-RNN Implementation
Improving modularity in EMI-RNN Implementation
Aug 19, 2018
@harsha-simhadri we are ready to merge. Please have a look and proceed with the merge. |
harsha-simhadri
approved these changes
Aug 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to improve the EMI-RNN implementation to make it more generic. Specifically, we want to support the following use-cases:
We require that all of the above be provided with full support for proper checkpointing, restoring from meta graphs, restoring from numpy files etc.
To allow the above, we've split the entire pipeline in to two parts:
Tensorflow Computation Graph
The tensorflow computation graph for our framework has the following three parts. Outputs from one part is fed as input to the next stage.
edgeml.graph.rnn:EMI_DataPipelin
.edgeml.graph.rnn:EMI_BasicLSTM
edgeml.trainer.emiTrainer
.The EMI driver algorithm
Since the EMI algorithm requires saving and restoring models from checkpoints during the training and belief update stages, we need close control on session management, graph construction and checkpoint managerment. Further, the additional ability to initialize the graphs from numpy files requires even more dirty coupling between the graph and the driver routines. I've henced moved all these dirty parts of the algorithm into a driver defined in
edgeml.trainer.EMI_Driver
.The upside is that user side code is cleaner with the ability to create and modify graphs as and when you want. The user though will have to forgo control on tensor flow sessions and will have to be careful when using session.