Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c++] Add a new value_size() method to RmwContext for RCU operations #145

Merged
merged 5 commits into from
Jul 4, 2019

Conversation

matthewbrookes
Copy link
Contributor

What:

  • add a value_size() method that allows the user to compute the new Value size with respect to the old Value
  • update tests etc to include the new method in RmwContext
  • add a test to show the use of this method for a growing string

Why:

  • supports RMW operations for a "growing" type such as a string, vector

Closes #136

@badrishc
Copy link
Contributor

Thanks, this looks reasonable. Since it's a core change we will need a bit more testing so might take some time to merge. Have you done any performance regression tests with the benchmarks?

@matthewbrookes
Copy link
Contributor Author

I haven't yet but I may get a chance over the weekend to run the RMW benchmark and compare

@matthewbrookes
Copy link
Contributor Author

Hey, I ran the RMW benchmark against master and against this new branch. You can see my results in the following spreadsheet.

https://docs.google.com/spreadsheets/d/1NozTEkdRO1RHmjFBRhT3oxQExCy3TlXPTheyvYBpdhA/edit?usp=sharing

Whilst the results suggest an improvement in performance with these modifications, I think the difference isn't statistically significant and suggests that this change would not impact performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[c++] Resize Value allocation during RmwCopy
2 participants