New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix memory safety issue in LightEpoch class #3

Merged

jahunter-m merged 1 commit into microsoft:master from zeebo:memory-safety

Aug 20, 2018

Contributor

zeebo commented Aug 18, 2018 •

edited

The constant kTableSize is the same as Thread::kMaxNumThreads: https://github.com/Microsoft/FASTER/blob/9c9d3e4c86f8e83c505290cf9f0baed549d3943b/cc/src/core/light_epoch.h#L120

The constructor allows one to specify a size but defaults to kTableSize: https://github.com/Microsoft/FASTER/blob/9c9d3e4c86f8e83c505290cf9f0baed549d3943b/cc/src/core/light_epoch.h#L140-L146

In Initialize, we set the table_ to an allocation based on the size: https://github.com/Microsoft/FASTER/blob/9c9d3e4c86f8e83c505290cf9f0baed549d3943b/cc/src/core/light_epoch.h#L153-L158

These methods loop over the table_ based on Thread::kMaxNumThreads instead of the appropriate size: https://github.com/Microsoft/FASTER/blob/9c9d3e4c86f8e83c505290cf9f0baed549d3943b/cc/src/core/light_epoch.h#L296-L318


          fix memory safety issue in LightEpoch class

f14b3d4

jahunter-m approved these changes

View reviewed changes

Contributor

jahunter-m left a comment

Good change; thanks.

jahunter-m merged commit b5f723f into microsoft:master

simonhf mentioned this pull request

C++ make test fails test #3 and test #4 never seems to end?! #87

Closed

wanghenshui mentioned this pull request

[C++] Fix unit test #582

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment