Add missing dependency on Microsoft.CodeAnalysis.Analyzers v1.1.0 #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kage. A dependency on package `Microsoft.CodeAnalysis.Analyzers` v1.1.0 implicitly shows up for csharp projects in VS2017, but that package version will not be downloaded / restored unless the dependency is called out explicitly in the .csproj file.
|
Makes sense, thanks. We also need to modify FASTER.core.nuspec and FASTER.core.debug.nuspec. |
Won't the Microsoft.CodeAnalysis.* packages only be required at build time, so downstream users of the .nupkg should not require to reference them? |
|
We have dynamic code generation and compilation going on when user creates a FASTER instance, and I thought maybe that would require it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing dependency on
Microsoft.CodeAnalysis.Analyzerspackage, to ensure correct version is restored.A dependency on package
Microsoft.CodeAnalysis.Analyzersv1.1.0 implicitly shows up for csharp projects in VS2017, but that package version will not be downloaded / restored on a new machine unless the dependency is called out explicitly in the .csproj file.