Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update flaml version in MathChat notebook #1095

Merged
merged 2 commits into from
Jul 2, 2023
Merged

update flaml version in MathChat notebook #1095

merged 2 commits into from
Jul 2, 2023

Conversation

yiranwu0
Copy link
Collaborator

update flaml version in MathChat notebook. (Line 16 and 32)

Why are these changes needed?

Related issue number

Checks

sonichi
sonichi approved these changes Jun 28, 2023
View reviewed changes
Copy link
Collaborator

@sonichi sonichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you like to add a link to the mathchat notebook in the doc website? Can do it in this PR: #1089

@yiranwu0
Copy link
Collaborator Author

Would you like to add a link to the mathchat notebook in the doc website? Can do it in this PR: #1089

Sure!

@yiranwu0 yiranwu0 requested a review from skzhang1 June 28, 2023 13:07
@sonichi
Copy link
Collaborator

sonichi commented Jun 29, 2023

Would you like to add a link to the mathchat notebook in the doc website? Can do it in this PR: #1089

Sure!

When would you add it?

@yiranwu0
Copy link
Collaborator Author

Would you like to add a link to the mathchat notebook in the doc website? Can do it in this PR: #1089

Sure!

When would you add it?

My bad. Just add it

@qingyun-wu qingyun-wu added this pull request to the merge queue Jun 29, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 29, 2023
@qingyun-wu qingyun-wu added this pull request to the merge queue Jun 29, 2023
@qingyun-wu qingyun-wu removed this pull request from the merge queue due to a manual request Jun 29, 2023
@sonichi
Copy link
Collaborator

sonichi commented Jul 2, 2023

@kevin666aa could you make the pydantic change in this PR?

@sonichi sonichi added this pull request to the merge queue Jul 2, 2023
@yiranwu0
Copy link
Collaborator Author

yiranwu0 commented Jul 2, 2023

@kevin666aa could you make the pydantic change in this PR?

Sure

@sonichi
Copy link
Collaborator

sonichi commented Jul 2, 2023

@kevin666aa could you make the pydantic change in this PR?

Sure

I've already merged with main. So that issue should be fixed.

Merged via the queue into main with commit 8236533 Jul 2, 2023
13 checks passed
@sonichi sonichi deleted the mathagent branch July 3, 2023 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonichi sonichi sonichi approved these changes

@qingyun-wu qingyun-wu qingyun-wu approved these changes

@skzhang1 skzhang1 Awaiting requested review from skzhang1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yiranwu0 @sonichi @qingyun-wu