Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify the initiation of chat #1131

Merged
merged 4 commits into from
Jul 18, 2023
Merged

simplify the initiation of chat #1131

merged 4 commits into from
Jul 18, 2023

Conversation

sonichi
Copy link
Collaborator

@sonichi sonichi commented Jul 17, 2023

Why are these changes needed?

  1. The current way of initiating a chat requires a complex way of writing the code. This PR makes it easier.
  2. Add generate_init_prompt in UserProxyAgent for subclasses to override. @kevin666aa @BeibinLi @qingyun-wu
  3. Make some private method public as needed.
  4. Improve the documentation for mathchat and function call.

Planning to release 2.0.0rc4 after merging.

Related issue number

Close #1081

Checks

@sonichi sonichi temporarily deployed to openai July 17, 2023 02:12 — with GitHub Actions Inactive
@sonichi sonichi temporarily deployed to openai July 17, 2023 02:42 — with GitHub Actions Inactive
@sonichi sonichi temporarily deployed to openai July 17, 2023 16:21 — with GitHub Actions Inactive
@sonichi sonichi temporarily deployed to openai July 17, 2023 20:23 — with GitHub Actions Inactive
@sonichi sonichi temporarily deployed to openai July 17, 2023 20:23 — with GitHub Actions Inactive
@sonichi sonichi temporarily deployed to openai July 17, 2023 20:23 — with GitHub Actions Inactive
@sonichi sonichi requested review from a team and JieyuZ2 July 18, 2023 01:54
pcdeadeasy
pcdeadeasy approved these changes Jul 18, 2023
View reviewed changes
Copy link
Collaborator

@pcdeadeasy pcdeadeasy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, it really does make the API more easy to use and intuitive.

@sonichi sonichi added this pull request to the merge queue Jul 18, 2023
qingyun-wu
qingyun-wu reviewed Jul 18, 2023
View reviewed changes
notebook/autogen_agent_web_info.ipynb
@@ -48,7 +48,7 @@
},
"outputs": [],
"source": [
"# %pip install flaml[autogen]==2.0.0rc3"
"# %pip install flaml[autogen]~=2.0.0rc4"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The initiation of chat in the example in this notebook should be updated to user.initiate_chat(...)?

notebook/autogen_agent_human_feedback.ipynb
@@ -44,7 +44,7 @@
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The initiation of chat in the example in this notebook should be updated to user.initiate_chat(...)?

Merged via the queue into main with commit 16f0fcd Jul 18, 2023
16 checks passed
@sonichi sonichi deleted the initchat branch July 18, 2023 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qingyun-wu qingyun-wu qingyun-wu left review comments

@pcdeadeasy pcdeadeasy pcdeadeasy approved these changes

@yiranwu0 yiranwu0 yiranwu0 approved these changes

@BeibinLi BeibinLi Awaiting requested review from BeibinLi

@JieyuZ2 JieyuZ2 Awaiting requested review from JieyuZ2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support new OpenAI models
4 participants
@sonichi @pcdeadeasy @qingyun-wu @yiranwu0