fix _append_oai_message #1195
Closed
fix _append_oai_message #1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonichi
reviewed
Aug 25, 2023
sonichi
reviewed
Aug 25, 2023
sonichi
reviewed
Aug 26, 2023
sonichi
reviewed
Aug 27, 2023
| return False | ||
| if role is not None: | ||
| if oai_message.get("role", "") == "function" and role != "function": | ||
| print(f"Warning: Attempt to overwrite role 'function' with {role}. Rejected.") |
There was a problem hiding this comment.
Have you tested? This will insert a warning in the conversation will may confuse readers. I don't know why we want to print this message.
There was a problem hiding this comment.
You are right, I will remove the warning add add a comment.
sonichi
reviewed
Aug 27, 2023
Co-authored-by: Chi Wang <wang.chi@microsoft.com>
sonichi
reviewed
Aug 30, 2023
Co-authored-by: Chi Wang <wang.chi@microsoft.com>
sonichi
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Fix bugs in function
_append_oai_messageRelated issue number
Checks