Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add max_depth to xgboost search space #282

Merged
merged 12 commits into from
Nov 23, 2021
Merged

add max_depth to xgboost search space #282

merged 12 commits into from
Nov 23, 2021

Conversation

sonichi
Copy link
Collaborator

@sonichi sonichi commented Nov 14, 2021

For improving performance on regression.
Example dataset: brazil_houses.

@sonichi sonichi requested review from qingyun-wu, mkyl and a team November 14, 2021 05:15
@@ -525,6 +525,10 @@ def search_space(cls, data_size, **params):
"init_value": 4,
"low_cost_init_value": 4,
},
"max_depth": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary to add max_depth to the search_space here? max_depth is removed from the space in XGBoostSklearnEstimator, and added in XGBoostLimitDepthEstimator

space["max_depth"] = {
            "domain": tune.randint(lower=1, upper=min(upper, 16)),
            "init_value": 1,
            "low_cost_init_value": 1,
        }

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XGBoostEstimator is not used as a default estimator. It's used for a custom estimator example. It's not necessary to add it here. I added it just to keep an example of including both 0 and non-zero in the domain of max_depth.

@sonichi sonichi merged commit ea6d28d into main Nov 23, 2021
@sonichi sonichi deleted the xgb branch November 23, 2021 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants