-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add max_depth to xgboost search space #282
Conversation
@@ -525,6 +525,10 @@ def search_space(cls, data_size, **params): | |||
"init_value": 4, | |||
"low_cost_init_value": 4, | |||
}, | |||
"max_depth": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it necessary to add max_depth
to the search_space here? max_depth
is removed from the space in XGBoostSklearnEstimator, and added in XGBoostLimitDepthEstimator
space["max_depth"] = {
"domain": tune.randint(lower=1, upper=min(upper, 16)),
"init_value": 1,
"low_cost_init_value": 1,
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
XGBoostEstimator is not used as a default estimator. It's used for a custom estimator example. It's not necessary to add it here. I added it just to keep an example of including both 0 and non-zero in the domain of max_depth.
For improving performance on regression.
Example dataset: brazil_houses.