-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Main page declutter and provide app version #182
Conversation
…ryOrchestrator into MainPageDeclutter
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
src/App/MainPage.xaml
Outdated
<StackPanel Orientation="Horizontal"> | ||
<!--<TextBlock FontFamily="Segoe MDL2 Assets" Text="" FontSize="30" VerticalAlignment="Center" />--> | ||
|
||
<SymbolIcon Symbol="More" Foreground="{ThemeResource TextFillColorSecondary}" Width="30" Height="30"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a different icon, not "...". "..." usually implies a interactive menu, not readonly information.
Alternates i like, https://docs.microsoft.com/en-us/windows/apps/design/style/segoe-ui-symbol-font:
src/App/MainPage.xaml
Outdated
</StackPanel> | ||
<StackPanel Orientation="Vertical" VerticalAlignment="Center" HorizontalAlignment="Left" Margin="5"> | ||
<TextBlock x:Name="OEMVersionHeader" Text="" VerticalAlignment="Center" HorizontalAlignment="Left" TextWrapping="Wrap" Style="{StaticResource CaptionTextBlockStyle}" IsTextSelectionEnabled="True"/> | ||
<TextBlock x:Name="AppVersionHeader" Text="" VerticalAlignment="Top" HorizontalAlignment="Left" TextWrapping="Wrap" Style="{StaticResource CaptionTextBlockStyle}" IsTextSelectionEnabled="True"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems odd that app version is visible but service version is hidden behind the button. Id consider hiding both
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Id also keep os version in the forefront, as OEMs frequently are juggling multiple OS images and devices might boot without working input/connectivity, so being able to quickly tell os version is useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have learned that app version is very useful for our own diagnosis as we can identify what is running in screen shots.
If there is no working input/connectivity, how is the information on OS version used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Hey microsoft i'm running factoryos build blah and i dont see input" 😄. Also not every device can have network working. ie CENT had issues there early in bringup.
My 2c is that very few apps so prominently display their version and i feel like oems care more about network connectivity & os version > app version.
you could consider adding a footer with more info too? or rotating through info like i did with the networks, but that wont help screenshots
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea of a footer, with small print. It would be akin to having a watermark on the Windows desktop. That would serve our purposes for analyzing screenshots.
I'd like to be deliberate about the layout, now that we will have multiple people working on this, and potentially multiple customers. We need to be able to innovate on the design, but with context about exactly which content is required by customers to be constantly visible. Ideally we would have this as part of a design spec, with each required element called out with the scenario it supports. PM involvement would be helpful for this, so we can also solicit direct feedback.
src/App/MainPage.xaml
Outdated
<SymbolIcon Symbol="More" Foreground="{ThemeResource TextFillColorSecondary}" Width="30" Height="30"/> | ||
</StackPanel> | ||
<Button.Flyout> | ||
<Flyout x:Name="ConfigFlyout" Opening="ConfigFlyout_Opening"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this is generic sysinfo, what else would be useful?
- battery info?
- total Memory?
- free disk space / used space?
- Serial Number
- Computer Hardware ID
- System manifest info
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Pull request contains merge conflicts. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Overview
Screenshots
Main Page
Responsiveness
Medium screen width:
![image](https://user-images.githubusercontent.com/30281766/131597067-68bb428a-a3b8-4837-96bd-c68ea2210a0f.png)
![image](https://user-images.githubusercontent.com/30281766/131597097-0880ecaf-336d-43c3-9a97-b364ec4d09b2.png)
Small screen width: