Support concurrency in IFeatureManagerSnapshot #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfoidl
reviewed
Sep 2, 2021
|
|
||
| return enabled; | ||
| return await evaluator.Value.ConfigureAwait(false); |
There was a problem hiding this comment.
You don't need to await the task here, just return it thus saving the async state machinery (allocations).
I'm not sure if the Lazy is needed. It's safer for race conditions in the sense of flag evaluations, but caching is a best effort solution which should be fast, so I would trade perf over possible "double evaluations".
There was a problem hiding this comment.
@gfoidl thanks that's a good improvement with the await removal.
I'm going to remove the double evaluation protection in this PR and think about that problem a bit more.
avanigupta
approved these changes
Sep 3, 2021
zhenlan
reviewed
Sep 3, 2021
zhenlan
approved these changes
Sep 4, 2021
jimmyca15
force-pushed
the
user/jimmyca/snapshotConcurrency
branch
from
b228b45
to
4465562
Compare
|
Had to rebase to resolve a merge conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of IFeatureManagerSnapshot is not thread safe. This PR enhances the implementation to support concurrency.
Addresses #136