Add variants for feature flags #250

amerjusupovic · 2023-08-04T19:01:16Z

No description provided.

…remanager

…agement interfaces. (#131)" (#139)" This reverts commit e531863.

…ces to keep existing usage possible. (#133)" (#138)" This reverts commit 8f9a7e4.

…finition

…t/FeatureManagement-Dotnet into ajusupovic/add-variants

… between customer use and variant use

…hods and interfaces to match

jimmyca15 · 2023-09-06T19:52:58Z

src/Microsoft.FeatureManagement/ConfigurationFeatureDefinitionProvider.cs

+
+                string rawFeatureStatus = configurationSection[ConfigurationFields.FeatureStatus];
+
+                string parseEnumErrorString = "Invalid {0} with value '{1}' for feature '{2}'.";


const string

jimmyca15 · 2023-09-06T19:54:25Z

src/Microsoft.FeatureManagement/ConfigurationFeatureDefinitionProvider.cs

+                {
+                    throw new FeatureManagementException(
+                        FeatureManagementError.InvalidConfigurationSetting,
+                        string.Format(parseEnumErrorString, nameof(FeatureStatus), rawFeatureStatus, configurationSection.Key));


Suggested change

string.Format(parseEnumErrorString, nameof(FeatureStatus), rawFeatureStatus, configurationSection.Key));

string.Format(parseEnumErrorString, ConfigurationFields.FeatureStatus, rawFeatureStatus, configurationSection.Key));

jimmyca15 · 2023-09-06T19:56:18Z

src/Microsoft.FeatureManagement/ConfigurationFeatureDefinitionProvider.cs

+                            Name = section[ConfigurationFields.NameKeyword],
+                            ConfigurationValue = section.GetSection(ConfigurationFields.VariantDefinitionConfigurationValue),
+                            ConfigurationReference = section[ConfigurationFields.VariantDefinitionConfigurationReference],
+                            StatusOverride = section.GetValue<StatusOverride>(ConfigurationFields.VariantDefinitionStatusOverride)


Why isn't this enum handled like others?

My bad, this should definitely be checked like the previous enums. I'll add a test for invalid StatusOverride value.

jimmyca15 · 2023-09-06T19:59:47Z

Wondering if we should have a preview branch that we merge this into.

rossgrambo · 2023-09-06T21:39:42Z

I think a preview branch is a good idea. We'll want to merge telemetry and variants somewhere outside of main.

amerjusupovic · 2023-09-07T22:35:00Z

Created a new preview branch from main.

src/Microsoft.FeatureManagement/Allocation/PercentileAllocation.cs

jimmyca15 · 2023-09-08T19:32:37Z

src/Microsoft.FeatureManagement/ConfigurationFeatureDefinitionProvider.cs

        private readonly IConfiguration _configuration;
        private readonly ConcurrentDictionary<string, FeatureDefinition> _definitions;
        private IDisposable _changeSubscription;
        private int _stale = 0;

+        const string ParseValueErrorString = "Invalid {0} with value '{1}' for feature '{2}'.";


How come {0} isn't in single quotes ? And shouldn't it be "Invalid settting '{0}' with value..."

I just based the format string off of the old error message, but since we're using a variable now I understand adding the single quotes.

jimmyca15 · 2023-09-08T19:34:48Z

src/Microsoft.FeatureManagement/Targeting/TargetingEvaluator.cs

+
+            if (from > to)
+            {
+                throw new ArgumentException($"Double {nameof(from)} cannot be larger than double {nameof(to)}.");


Both usage of "double" should be replaced with "value of"

jimmyca15 · 2023-09-08T19:36:23Z

src/Microsoft.FeatureManagement/FeatureManager.cs

+                    {
+                        if (string.IsNullOrEmpty(percentile.Variant))
+                        {
+                            _logger.LogWarning($"Missing variant name for {nameof(featureDefinition.Allocation.Percentile)} allocation in feature {featureDefinition.Name}");


The way this is used it seems like it should just be hardcoded literal "percentile"

Co-authored-by: Ross Grambo <rossgrambo@microsoft.com>

…t/FeatureManagement-Dotnet into ajusupovic/add-variants

rossgrambo · 2023-09-08T20:16:27Z

src/Microsoft.FeatureManagement/FeatureManager.cs

+                        percentile.From,
+                        percentile.To,
+                        _assignerOptions.IgnoreCase,
+                        featureDefinition.Allocation.Seed))


If seed is null, we should use feature name.

This would ensure that flags have different seeds by default. This ensures whoever gets mapped to 1% isn't thrown into every experiment always.

Although, there is an argument that Allocation might not want to default to the same % mapping that targeting uses. Because a targeting filter of 50% with an allocation of 50% means 100% of the 50% would be allocated.

So perhaps we should default to feature name, but add "allocation" at the end or something. @jimmyca15 what do you think?

@rossgrambo makes sense. Although I would put any addition before the flag name since it's unchanging and acts like prefix in my eyes.

src/Microsoft.FeatureManagement/FeatureManager.cs

Co-authored-by: Jimmy Campbell <jimmyca@microsoft.com>

zhiyuanliang-ms · 2023-09-29T13:45:54Z

src/Microsoft.FeatureManagement/FeatureManager.cs

-                        if (string.Equals(featureFilterConfiguration.Name, "AlwaysOn", StringComparison.OrdinalIgnoreCase))
+                        // Handle AlwaysOn and On filters
+                        if (string.Equals(featureFilterConfiguration.Name, "AlwaysOn", StringComparison.OrdinalIgnoreCase) ||
+                                string.Equals(featureFilterConfiguration.Name, "On", StringComparison.OrdinalIgnoreCase))


Should we mention that the filter name "On" is also occupied and it is a built-in filter in the document.

amerjusupovic added 30 commits July 3, 2023 14:35

in progress, add new classes for variants and define methods in featu…

d28bf88

…remanager

Revert "Revert "Add cancellation token parameter to async feature man…

c1451d3

…agement interfaces. (#131)" (#139)" This reverts commit e531863.

Revert "Revert "Added default value for cancellation token in interfa…

d087e7b

…ces to keep existing usage possible. (#133)" (#138)" This reverts commit 8f9a7e4.

fix any conflicts left from adding cancellationToken back

87aa5a8

add in progress changes to allocation and featuredefinitionprovider

55e2264

add examples for testing

1918bf9

fix adding new featuredefinition properties from featuremanagement de…

3e3ab2e

…finition

progress adding getvariant logic classes

703f89a

continued

e225d22

remove repeated code in contextual targeting

c233ec6

fix version of contextual filter

3a8bac1

more progress on getting the contextual allocator to work

fa2133c

about to test getvariant

86ff346

add example to test

c445e46

Merge branch 'ajusupovic/add-variants' of https://github.com/microsof…

cd09ec2

…t/FeatureManagement-Dotnet into ajusupovic/add-variants

add snapshot changes

0a4dcfb

Merge branch 'ajusupovic/add-variants' of https://github.com/microsof…

82055ad

…t/FeatureManagement-Dotnet into ajusupovic/add-variants

variant can be detected and retrieved from getvariantasync

34375e6

progress on allocation logic, add comments where consideration needed

1f6318b

add use of optionsresolver for reference, todo work on isenabledasync…

1f76adc

… between customer use and variant use

All working except couple TODOs, need to add unit tests

ee98bbe

remove some comments, add null check where needed

42a7cbc

update todo comments

3df6f32

fix line eols

cbc322e

add unit test, in progress

7e801d9

TODOs in progress, need to restructure featurevariantassigner design

ee3fdb0

fix seed logic

76ad51f

update comments, status logic

b7a97a7

remove unnecessary files for custom assigners, fix featuremanager met…

370228e

…hods and interfaces to match

fix naming from allocator to assigner for classes and files

a259e23

jimmyca15 reviewed Sep 6, 2023

View reviewed changes

amerjusupovic added 5 commits September 6, 2023 17:13

test failing, fixed PR revisions

6dfb3ec

fix invalid scenarios test

827c0ae

simplify context in test

656ec67

remove unused using

bed8093

remove unused param

03e8e47

amerjusupovic changed the base branch from main to preview September 7, 2023 22:34

rossgrambo reviewed Sep 8, 2023

View reviewed changes

src/Microsoft.FeatureManagement/Allocation/PercentileAllocation.cs Outdated Show resolved Hide resolved

rossgrambo reviewed Sep 8, 2023

View reviewed changes

src/Microsoft.FeatureManagement/Allocation/PercentileAllocation.cs Outdated Show resolved Hide resolved

jimmyca15 reviewed Sep 8, 2023

View reviewed changes

jimmyca15 approved these changes Sep 8, 2023

View reviewed changes

amerjusupovic and others added 3 commits September 8, 2023 13:03

Clarify how From and To bounds work in PercentileAllocation

e1cb0d2

Co-authored-by: Ross Grambo <rossgrambo@microsoft.com>

fix error messages

23ff1ef

Merge branch 'ajusupovic/add-variants' of https://github.com/microsof…

2340b8c

…t/FeatureManagement-Dotnet into ajusupovic/add-variants

rossgrambo reviewed Sep 8, 2023

View reviewed changes

add feature name as default seed with allocation prefix

3827494

jimmyca15 reviewed Sep 12, 2023

View reviewed changes

src/Microsoft.FeatureManagement/FeatureManager.cs Outdated Show resolved Hide resolved

Update src/Microsoft.FeatureManagement/FeatureManager.cs

755687e

Co-authored-by: Jimmy Campbell <jimmyca@microsoft.com>

jimmyca15 approved these changes Sep 12, 2023

View reviewed changes

amerjusupovic merged commit b1b1562 into preview Sep 13, 2023
2 checks passed

jimmyca15 mentioned this pull request Sep 28, 2023

Enable dynamic configuration values to be retrieved based on a feature. #5

Open

zhiyuanliang-ms reviewed Sep 29, 2023

View reviewed changes

zhiyuanliang-ms mentioned this pull request Mar 10, 2024

Consider adding default for CancellationToken parameters in interfaces / classes in 4.0.0 #376

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add variants for feature flags #250

Add variants for feature flags #250

amerjusupovic commented Aug 4, 2023

jimmyca15 Sep 6, 2023

jimmyca15 Sep 6, 2023

jimmyca15 Sep 6, 2023

amerjusupovic Sep 6, 2023 •

edited

jimmyca15 commented Sep 6, 2023

rossgrambo commented Sep 6, 2023

amerjusupovic commented Sep 7, 2023

jimmyca15 Sep 8, 2023

amerjusupovic Sep 8, 2023

jimmyca15 Sep 8, 2023

jimmyca15 Sep 8, 2023 •

edited

rossgrambo Sep 8, 2023

rossgrambo Sep 8, 2023

rossgrambo Sep 8, 2023

jimmyca15 Sep 8, 2023

zhiyuanliang-ms Sep 29, 2023


		string rawFeatureStatus = configurationSection[ConfigurationFields.FeatureStatus];

		string parseEnumErrorString = "Invalid {0} with value '{1}' for feature '{2}'.";

	string.Format(parseEnumErrorString, nameof(FeatureStatus), rawFeatureStatus, configurationSection.Key));
	string.Format(parseEnumErrorString, ConfigurationFields.FeatureStatus, rawFeatureStatus, configurationSection.Key));

Add variants for feature flags #250

Add variants for feature flags #250

Conversation

amerjusupovic commented Aug 4, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

amerjusupovic Sep 6, 2023 • edited

Choose a reason for hiding this comment

jimmyca15 commented Sep 6, 2023

rossgrambo commented Sep 6, 2023

amerjusupovic commented Sep 7, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jimmyca15 Sep 8, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

amerjusupovic Sep 6, 2023 •

edited

jimmyca15 Sep 8, 2023 •

edited