Adds telemetry pipeline #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd a publisher instance for app insights.
rossgrambo
requested review from
zhenlan,
jimmyca15,
amerjusupovic and
mrm9084
...pInsightsTelemetryPublisher/Microsoft.FeatureManagement.AppInsightsTelemetryPublisher.csproj
Outdated
Show resolved
Hide resolved
src/Microsoft.FeatureManagement.AppInsightsTelemetryPublisher/ServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
jimmyca15
reviewed
Sep 12, 2023
src/Microsoft.FeatureManagement/Targeting/ContextualTargetingFilter.cs
Outdated
Show resolved
Hide resolved
jimmyca15
reviewed
Sep 12, 2023
jimmyca15
reviewed
Sep 12, 2023
jimmyca15
reviewed
Sep 12, 2023
jimmyca15
reviewed
Sep 12, 2023
jimmyca15
reviewed
Sep 12, 2023
src/Microsoft.FeatureManagement.AppInsightsTelemetryPublisher/ServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
jimmyca15
reviewed
Sep 12, 2023
src/Microsoft.FeatureManagement.AppInsightsTelemetryPublisher/ServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
jimmyca15
reviewed
Sep 12, 2023
src/Microsoft.FeatureManagement.AppInsightsTelemetryPublisher/TelemetryPublisherAppInsights.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Jimmy Campbell <jimmyca@microsoft.com>
Co-authored-by: Jimmy Campbell <jimmyca@microsoft.com>
…TelemetryPublisherAppInsights.cs Co-authored-by: Jimmy Campbell <jimmyca@microsoft.com>
jimmyca15
reviewed
Sep 12, 2023
src/Microsoft.FeatureManagement.AppInsightsTelemetryPublisher/TelemetryPublisherAppInsights.cs
Outdated
Show resolved
Hide resolved
jimmyca15
reviewed
Sep 12, 2023
jimmyca15
reviewed
Sep 12, 2023
jimmyca15
reviewed
Sep 12, 2023
Co-authored-by: Jimmy Campbell <jimmyca@microsoft.com>
…eatureManagement-Dotnet into rossgrambo/telemetry
zhenlan
reviewed
Oct 4, 2023
zhenlan
reviewed
Oct 4, 2023
zhenlan
reviewed
Oct 4, 2023
jimmyca15
reviewed
Oct 4, 2023
jimmyca15
reviewed
Oct 4, 2023
jimmyca15
reviewed
Oct 4, 2023
jimmyca15
reviewed
Oct 4, 2023
jimmyca15
reviewed
Oct 4, 2023
|
Created another PR that handles updating the build targets to Net6 and Net7 #271 |
|
Merged main into preview and persisted that here. Meaning we now test against/target net48 & net6.0 & net7.0 |
zhenlan
reviewed
Oct 5, 2023
jimmyca15
reviewed
Oct 6, 2023
jimmyca15
reviewed
Oct 6, 2023
src/Microsoft.FeatureManagement/ConfigurationFeatureDefinitionProvider.cs
Show resolved
Hide resolved
jimmyca15
reviewed
Oct 7, 2023
jimmyca15
reviewed
Oct 7, 2023
src/Microsoft.FeatureManagement/ConfigurationFeatureDefinitionProvider.cs
Outdated
Show resolved
Hide resolved
zhenlan
reviewed
Oct 9, 2023
jimmyca15
approved these changes
Oct 9, 2023
|
Ooooooooooooo AM EXCITE!!!! |
|
|
||
| telemetryEnabled = configurationSection.GetValue<bool>("TelemetryEnabled"); | ||
|
|
||
| IConfigurationSection telemetryMetadataSection = configurationSection.GetSection("TelemetryMetadata"); |
There was a problem hiding this comment.
Should "TelemetryMetadata" be moved into ConfigurationFields.cs as a const string?
| @@ -283,6 +287,17 @@ We support | |||
| variants.Add(variant); | |||
| } | |||
| } | |||
|
|
|||
| telemetryEnabled = configurationSection.GetValue<bool>("TelemetryEnabled"); | |||
There was a problem hiding this comment.
Should "TelemetryEnabled" be moved into ConfigurationFields.cs as a const string?
| @@ -142,6 +146,16 @@ private async Task<bool> IsEnabledWithVariantsAsync<TContext>(string feature, TC | |||
| await sessionManager.SetAsync(feature, isFeatureEnabled).ConfigureAwait(false); | |||
| } | |||
|
|
|||
| if (featureDefinition.TelemetryEnabled) | |||
There was a problem hiding this comment.
if (featureDefinition != null && featureDefinition.TelemetryEnabled)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an evaluation event, publisher interface, and an implementation of the publisher for app insights.
This is the first of multiple PRs to support Telemetry. The goal of this PR is to empower developers to emit telemetry.
Excluded the example app from this PR to make reviews easier.
Also excluded is a way for developers to include or exclude fields. Currently the schema is declared inline.