Feature-based Injection #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiyuanliang-ms
requested review from
jimmyca15,
zhenlan,
rossgrambo and
amerjusupovic
…ent-Dotnet into zhiyuanliang/feature-based-injection
…ent-Dotnet into zhiyuanliang/feature-based-injection
rossgrambo
reviewed
Jan 11, 2024
zhiyuanliang-ms
force-pushed
the
zhiyuanliang/feature-based-injection
branch
from
b28615c
to
a7b8f0f
Compare
zhenlan
reviewed
Jan 18, 2024
rossgrambo
reviewed
Jan 18, 2024
src/Microsoft.FeatureManagement.Telemetry.ApplicationInsights/TelemetryClientExtensions.cs
Outdated
Show resolved
Hide resolved
zhiyuanliang-ms
force-pushed
the
zhiyuanliang/feature-based-injection
branch
from
d5079b3
to
6eb165f
Compare
zhiyuanliang-ms
force-pushed
the
zhiyuanliang/feature-based-injection
branch
from
596332d
to
f48767c
Compare
rossgrambo
reviewed
Jan 25, 2024
rossgrambo
reviewed
Jan 25, 2024
zhenlan
reviewed
Jan 26, 2024
Closed
jimmyca15
reviewed
Jan 30, 2024
src/Microsoft.FeatureManagement/FeatureManagementBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
jimmyca15
reviewed
Jan 30, 2024
src/Microsoft.FeatureManagement/FeatureManagementBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
jimmyca15
reviewed
Jan 30, 2024
src/Microsoft.FeatureManagement/FeatureManagementBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
jimmyca15
reviewed
Jan 30, 2024
|
An exception should be thrown if there are multiple |
rossgrambo
reviewed
Feb 6, 2024
src/Microsoft.FeatureManagement/FeatureManagementBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
rossgrambo
reviewed
Feb 6, 2024
src/Microsoft.FeatureManagement/FeatureManagementBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
rossgrambo
approved these changes
Feb 8, 2024
jimmyca15
reviewed
Feb 8, 2024
src/Microsoft.FeatureManagement/FeatureManagementBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
jimmyca15
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
2 unresolved minor comments on my end. Everything else looks good. Thanks @zhiyuanliang-ms !
zhiyuanliang-ms
force-pushed
the
zhiyuanliang/feature-based-injection
branch
from
044ada8
to
cbda0c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is targeting on the potential user case is to inject services based on variants. For example, if the variant was an algorithm name, and a controller constructor took IHashAlgorithm as a constructor parameter. How could we make it so that the implementation was dependent upon an assigned variant?
Also, it tries to resolve #39.
This draft PR provides one APIs:
FeatureManagementBuilder.AddFeaturedService<TService>Example usage can be found here: examples/FeatureBasedInjectionPOC/Program.cs
Open to suggestion for the design of feature-based injection.