This repository has been archived by the owner on Apr 11, 2024. It is now read-only.
Allow not to use UIImageAsset on iOS 13 #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levinli303
force-pushed
the
allow-for-no-image-asset
branch
from
a18e76e
to
67ce9fb
Compare
|
@zhuorantan @li-bei got time to review this PR? |
zhuorantan
suggested changes
Jul 24, 2020
levinli303
force-pushed
the
allow-for-no-image-asset
branch
from
a79e3b8
to
0646f9c
Compare
14 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's an issue: registering an UIImage with a
contentother than _UIImageCGImageContent will wipe out the images stored in UIImageAsset, so this PR allows to fallback to DynamicImage on iOS 13 with images.Includes:
useUIImageAssetin register/setup the dark mode manager, when off on iOS 13, it will use DynamicImage instead of UIImageAssetimageWithConfiguration:in DynamicImage for iOS 13, since the image fetched on iOS 13 does necessarily follow the overrideTraitCollection