Skip to content

Commit

Permalink
add test
Browse files Browse the repository at this point in the history
  • Loading branch information
Jatin Garg authored and Jatin Garg committed Apr 19, 2024
1 parent 84e2449 commit 22a7932
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions packages/drivers/odsp-driver/src/fetchSnapshot.ts
Original file line number Diff line number Diff line change
Expand Up @@ -258,9 +258,10 @@ async function redeemSharingLink(
const disableUsingTenantDomain = loggerToMonitoringContext(logger).config.getBoolean(
"Fluid.Driver.Odsp.DisableUsingTenantDomainForSharesApi",
);
// There is an issue where if we use the siteUrl in /shares, then the allowed length of url is just a few hundred characters
// There is an issue where if we use the siteUrl in /shares, then the allowed length of url is just a few hundred characters(300-400)
// and we fail to do the redeem. But if we use the tenant domain in the url, then the allowed length becomes 2048. So, first
// construct the url for /shares using tenant domain but to be on safer side, fallback to using the siteUrl.
// construct the url for /shares using tenant domain but to be on safer side, fallback to using the siteUrl. We get tenant domain
// by getting origin of the siteUrl.
if (!disableUsingTenantDomain) {
try {
await callSharesAPI(new URL(odspResolvedUrl.siteUrl).origin);
Expand Down

0 comments on commit 22a7932

Please sign in to comment.