Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable strictNullChecks throughout #2358

Closed
GaryWilber opened this issue Jun 2, 2020 · 4 comments
Closed

Enable strictNullChecks throughout #2358

GaryWilber opened this issue Jun 2, 2020 · 4 comments
Labels
refactor Code refactoring and cleanup

Comments

@GaryWilber
Copy link
Contributor

The TypeScript option strictNullChecks is currently disabled in most server/routerlicious packages. We should work on enabling it.
@GaryWilber GaryWilber added refactor Code refactoring and cleanup area: server Server related issues (routerlicious) labels Jun 2, 2020
@ghost ghost added the triage label Jun 2, 2020
@GaryWilber GaryWilber removed the triage label Jun 2, 2020
@ghost ghost added the triage label Jun 2, 2020
@curtisman curtisman added this to the Next 2020 milestone Jun 2, 2020
@curtisman curtisman removed the triage label Jun 2, 2020
@markfields
Copy link
Member

Updating title and removing area: server tag. All our packages should use strictNullChecks. Packages under examples dir are maybe a lower priority... but really everything should.

@markfields markfields removed the area: server Server related issues (routerlicious) label Oct 5, 2020
@markfields
Copy link
Member

Also worth auditing/considering the strict-boolean-expressions ESLint rule. See also: #2809 and #3770

@markfields markfields changed the title Enable strictNullChecks in server code Enable strictNullChecks throughout Oct 5, 2020
@curtisman curtisman mentioned this issue Jan 13, 2021
Merged
curtisman added a commit that referenced this issue Jan 13, 2021
@curtisman
Partial change to fix some warning if strictNullCheck is enabled for …
1a58fe5 
…merge-tree package (#4812)

strictNullCheck for merge-tree is not enabled by default yet. Doing it in multiple PR to manage churn and change size.

Mostly simple change to typing to add undefined

Related to #2358
This was referenced Feb 3, 2021
Merged
Merged
Merged
Merged
Merged
Merged
@GaryWilber GaryWilber linked a pull request Feb 19, 2021 that will close this issue
Enable strict null checks in lambdas package #5204
Merged
@GaryWilber GaryWilber removed a link to a pull request Feb 19, 2021
Enable strict null checks in lambdas package #5204
Merged
This was referenced Feb 19, 2021
Merged
Merged
@ghost ghost added the status: stale label Jun 8, 2021
@ghost
Copy link

ghost commented Jun 8, 2021

This issue has been automatically marked as stale because it has had no activity for 180 days. It will be closed if no further activity occurs within 8 days of this comment. Thank you for your contributions to Fluid Framework!

@markfields
Copy link
Member

@GaryWilber - if you want this issue to stick around, reopen, maybe noting which packages still need to be fixed up. Thank you and @curtisman for your work here btw!

@ghost ghost removed the status: stale label Jun 12, 2021
@danielroney danielroney removed this from the Next milestone Jun 15, 2021
Josmithr pushed a commit to Josmithr/FluidFramework that referenced this issue Aug 4, 2022
@octogonz
Merge pull request microsoft#2358 from microsoft/octogonz/npmignore-f…
1208e65 
…ixups

Fix up .npmignore files for projects in this repo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor Code refactoring and cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@curtisman @markfields @GaryWilber @danielroney