Match pending summary ack with sent summary #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladsud
reviewed
Sep 24, 2019
This was referenced Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up change for the summarizer waiting for summary ack. Now instead of waiting for any summary ack/nack, it waits specifically for the one corresponding to its own pending summary op. It does this by listening to the broadcast summary op, and getting its sequence number (matching by client id and reference sequence number). Then it can match to the summary ack/nack using the summary sequence number, since that alone is unique.
Also made it so the Container Runtime unit tests are actually executed.
Side note: I also tested matching the broadcast summary op to the pending op via the summary handle rather than the reference sequence number, and that also seemed to work fine with some brief local testing. If that is preferable, let me know and I can update the PR.