Introduce ConnectionErrorType enum for modeling connection errors to hosts #1581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladsud
reviewed
Mar 20, 2020
ruchika-m
reviewed
Mar 20, 2020
markfields
commented
Mar 20, 2020
|
Updated per Ruchika's request. Need to fix the tests. |
vladsud
approved these changes
Mar 22, 2020
ruchika-m
reviewed
Mar 23, 2020
ruchika-m
approved these changes
Mar 23, 2020
vladsud
approved these changes
Mar 24, 2020
To hopefully fix "missing" export of base class ErrorWithProps
markfields
commented
Mar 25, 2020
| @@ -643,13 +643,14 @@ export class DeltaManager extends EventEmitter implements IDeltaManager<ISequenc | |||
| replayFrom: from, | |||
| to, | |||
| }); | |||
| const closeError: IConnectionError = { | |||
There was a problem hiding this comment.
@vladsud - This is interesting - the fact that someone can just instantiate an object adhering to the interface means they miss out on extending ErrorWithProps and Error. Not extending Error is probably ok since it's not thrown anyway, but it won't be logged properly without extending ErrorWithProps. Not sure how to enforce this, something to discuss... Worthy of an issue?
markfields
commented
Mar 25, 2020
| undefined /*statusCode*/, | ||
| undefined /*retryAfterSeconds*/, | ||
| "Online", | ||
| ) as IGenericNetworkError; |
There was a problem hiding this comment.
Note to self: This is sloppy, I'd like to revisit this in a later change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimal fix for #1354. It's a non-breaking change so they can switch over from raw
statusCodeto the more semanticconnectionErrorat their leisure.More thought could probably be put into the model here, probably in a later change:
connectionErrorinNetwork.ts?IConnectionErrorup into other interfaces similarly to howIErroris defined, and replace the classNetworkErrorwith different specific implementations, maybe with a little factory method to abstract the differences from callers.Also, I might propose some refactoring of
OdspNetworkErrorin another change, it's also modeled a little strangely (e.g. passing in fake400status codes).