-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v2int/7.4] Fix bundle size #19229
[v2int/7.4] Fix bundle size #19229
Conversation
…ld (microsoft#18771)" This reverts commit cbaf3db.
/azp run Build - client packages |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
⯆ @fluid-example/bundle-size-tests: -90.39 KB
Baseline commit: 2813345 |
I'll hold merging this, since @jason-ha is working on an alternative. Good to see it pass CI though. |
@alexvy86 protocol-defs is an independent package and isn't released from the 7.4 client release branch. If you need to release a new version of protocol-defs, make the changes in main and release it, then you can update the deps on release branches as needed. However, also note that using a different protocol-defs version will require the same change in server, and then the server deps in client also have to be updated. |
Replaced by #19239 |
Description
Reverts "build(protocol-definitions): Produce correct types in ESM bui…ld (#18771)".
This reverts commit cbaf3db, which might be the culprit of the increase in bundle size.
Reviewer Guidance
The review process is outlined on this wiki page.