Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2int/7.4] Fix bundle size #19229

Closed

Conversation

alexvy86
Copy link
Contributor

Description

Reverts "build(protocol-definitions): Produce correct types in ESM bui…ld (#18771)".

This reverts commit cbaf3db, which might be the culprit of the increase in bundle size.

Reviewer Guidance

The review process is outlined on this wiki page.

@alexvy86 alexvy86 requested review from msfluid-bot and a team as code owners January 12, 2024 16:54
@alexvy86
Copy link
Contributor Author

/azp run Build - client packages

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@alexvy86 alexvy86 requested a review from a team as a code owner January 12, 2024 18:19
@msfluid-bot
Copy link
Collaborator

@fluid-example/bundle-size-tests: -90.39 KB
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 494.74 KB 485.17 KB -9.56 KB
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 285.18 KB 275.82 KB -9.36 KB
loader.js 178.28 KB 167.41 KB -10.87 KB
map.js 90.94 KB 80.54 KB -10.4 KB
matrix.js 187.44 KB 176.87 KB -10.57 KB
odspDriver.js 98.5 KB 90.25 KB -8.25 KB
odspPrefetchSnapshot.js 52.02 KB 41.82 KB -10.2 KB
sharedString.js 205.39 KB 195.01 KB -10.38 KB
sharedTree2.js 312.91 KB 301.87 KB -11.04 KB
Total Size 1.98 MB 1.89 MB -90.39 KB

Baseline commit: 2813345

Generated by 🚫 dangerJS against b020997

@alexvy86
Copy link
Contributor Author

I'll hold merging this, since @jason-ha is working on an alternative. Good to see it pass CI though.

@alexvy86
Copy link
Contributor Author

Confirming the 90kb of bundle size improvement is also great 😄
image

@tylerbutler
Copy link
Member

@alexvy86 protocol-defs is an independent package and isn't released from the 7.4 client release branch. If you need to release a new version of protocol-defs, make the changes in main and release it, then you can update the deps on release branches as needed.

However, also note that using a different protocol-defs version will require the same change in server, and then the server deps in client also have to be updated.

@jason-ha
Copy link
Contributor

Replaced by #19239

@jason-ha jason-ha closed this Jan 13, 2024
@alexvy86 alexvy86 deleted the fix-bundle-size branch February 15, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants