Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(multiview-triangle-view): use node16 module resolution #19994

Merged
merged 10 commits into from
Mar 13, 2024
Merged

build(multiview-triangle-view): use node16 module resolution #19994

merged 10 commits into from
Mar 13, 2024

Conversation

DLehenbauer
Copy link
Contributor

Semi-automatic PR to switch to node16 module resolution

@github-actions github-actions bot added area: examples Changes that focus on our examples dependencies Pull requests that update a dependency file base: main PRs targeted against main branch labels Mar 6, 2024
@DLehenbauer DLehenbauer marked this pull request as ready for review March 7, 2024 19:23
tylerbutler
tylerbutler approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@tylerbutler tylerbutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Probably worth merging latest main and resetting/regenning the lockfile before merge.

@DLehenbauer DLehenbauer enabled auto-merge (squash) March 12, 2024 15:14
@jason-ha
Copy link
Contributor

@DLehenbauer, what is left that wasn't covered by #20085?

@github-actions github-actions bot removed area: examples Changes that focus on our examples dependencies Pull requests that update a dependency file labels Mar 13, 2024
@DLehenbauer
Copy link
Contributor Author

Merged with PR #20085

@DLehenbauer DLehenbauer merged commit 1d07902 into main Mar 13, 2024
27 checks passed
@DLehenbauer DLehenbauer deleted the multiview-triangle-view branch March 13, 2024 19:23
@jason-ha
Copy link
Contributor

@tylerbutler, GitHub lets us commit no change PRs? 1d07902

@tylerbutler
Copy link
Member

@tylerbutler, GitHub lets us commit no change PRs? 1d07902

Looks like it. I'm guessing we could prevent this by requiring an up to date base branch but that's been a tough sell so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerbutler tylerbutler tylerbutler approved these changes

@jason-ha jason-ha jason-ha approved these changes

@sonalideshpandemsft sonalideshpandemsft Awaiting requested review from sonalideshpandemsft

@RishhiB RishhiB Awaiting requested review from RishhiB

Assignees
No one assigned
Labels
base: main PRs targeted against main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DLehenbauer @jason-ha @tylerbutler