Port (RC.2.0): Fix ApplyStashedOp for DataStore and DDS Attach Messages #20319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds tests to ensure the correct behavior of serialize after a container fails an attach attempt and goes into the attaching state. The tests include validation that a data store and a DDS created while attaching can be dealt with on rehydrate. [AB#5917](https://dev.azure.com/fluidframework/235294da-091d-4c29-84fc-cdfc3d90890b/_workitems/edit/5917)
…0218) This change adds support to applyStashedOp for DataStore and DDS attach messages while in a detached state, and unifies that with how applyStashedOp works in the attached state. Related [AB#7452](https://dev.azure.com/fluidframework/235294da-091d-4c29-84fc-cdfc3d90890b/_workitems/edit/7452) --------- Co-authored-by: Tony Murphy <anthonm@microsoft.com>
dannimad
approved these changes
Mar 26, 2024
anthony-murphy
merged commit eeaea1c
into
microsoft:release/client/2.0.0-rc.2.0
28 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting #20218 to RC.2.0, as this issue will block testing of applying stashed ops while detached