Expose configuredSharedTree #20332
Merged
Expose configuredSharedTree #20332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: dds
examples/data-objects/inventory-app/src/reactSharedTreeView.tsx
Outdated
Show resolved
Hide resolved
| * TreeCompressionStrategy, | ||
| * configuredSharedTree, | ||
| * typeboxValidator, | ||
| * // eslint-disable-next-line import/no-internal-modules |
There was a problem hiding this comment.
Does this eslint directive need to be in the example?
There was a problem hiding this comment.
I considered removing it. I kinda like that it helps highlight that despite this pattern usually not being allowed, in this case (reaching into a package for on of our release tag rollups) is supported.
I don't have a strong opinion either way though, so if anyone has a preference, I'll go with that.
There was a problem hiding this comment.
No strong opinion either. Feel free to resolve without further changes.
Co-authored-by: yann-achard-MS <97201204+yann-achard-MS@users.noreply.github.com>
yann-achard-MS
approved these changes
Mar 26, 2024
⯅ @fluid-example/bundle-size-tests: +62 Bytes
Baseline commit: f49f533 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Expose an
@internalapi,configuredSharedTreewhich can be used to opt into various internal/debug shared tree settings.This should help cases like #20274 root cause the bug.
Reviewer Guidance
The review process is outlined on this wiki page.