fix(datastore): Fix bundle size regression caused by lodash import changes #20441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anges (microsoft#20421) This PR fixes the bundle size regression that was caused by the changes in the lodash import syntax. The syntax was initially changed to accommodate the new node 16 module resolution (microsoft#18826). The syntax it was changed to caused the entire lodash library to be loaded. This PR fixes this by replacing cloneDeep with structuredClone
clarenceli-msft
approved these changes
Apr 3, 2024
scottn12
merged commit 665a6d5
into
microsoft:release/client/2.0.0-rc.2.0
28 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick from 3aa12dd
This PR fixes the bundle size regression that was caused by the changes in the lodash import syntax.
The syntax was initially changed to accommodate the new node 16 module resolution (#18826). The syntax it was changed to caused the entire lodash library to be loaded. This PR fixes this by replacing cloneDeep with structuredClone.