fix(datastore): Replace structuredClone with custom deep clone function #20465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noencke
approved these changes
Apr 4, 2024
anthony-murphy
approved these changes
Apr 4, 2024
⯆ @fluid-example/bundle-size-tests: -2.06 KB
Baseline commit: 643a5fd |
scottn12
merged commit 061dcc9
into
microsoft:release/client/2.0.0-rc.1.0
22 checks passed
scottn12
added a commit
to scottn12/FluidFramework
that referenced
this pull request
Apr 4, 2024
…on (microsoft#20465) This PR removes the use of `structuredClone` in `@fluidframework/datastore`, as it was unable to handle ArrayBuffer data types on older browser setups.
scottn12
added a commit
to scottn12/FluidFramework
that referenced
this pull request
Apr 4, 2024
…on (microsoft#20465) This PR removes the use of `structuredClone` in `@fluidframework/datastore`, as it was unable to handle ArrayBuffer data types on older browser setups.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the use of
structuredClonein@fluidframework/datastore, as it was unable to handle ArrayBuffer data types on older browser setups.