Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main > Release/Client/rc2]: Use tenant domain instead of siteUrl in /shares api in ODSP driver (#20738) #20770

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

jatgarg
Copy link
Contributor

@jatgarg jatgarg commented Apr 21, 2024

Description

Task Link

To load a Fluid container, host/app provides a URL which is used to talk to service to load the container. That URL can be a share link which host/app specifies explicitly to Fluid that the URL is a share link. Fluid then uses that link to fetch the snapshot for the container. User sometimes don’t have permissions initially, so to save COGS, Fluid supply this share link in body of trees latest call to the service, so that in 1 network call, we can do the redeem and also fetch the snapshot. Sometimes this redeem on service side fails (in case it is first time sharing with that user), then the service throws on the trees latest call. Fluid catches this exception and determines/guess if this is because of redeem failure at service side and then fallback to doing redeem by itself using the /shares API. Once the redeem fails even in /shares API, the container load fails.

In this issue, for outlook Win32 the /shares API (Documentation link for API:
Link) call is failing because of the length limitation on the API. There are 2 ways to call the /shares API(for Fluid use),

Method 1: site-url/_api/v2.0/shares/{shareID}
This has length limitation of about 400 characters.

Method 2: tenant-domain/_api/v2.0/shares/{shareID} Then the length limitation is about 2048 characters. where this, share ID is generated by encoding the share link supplied by the app in the above load request. So, encoding longer URL will give longer shareID.

Tenant-domain can be extracted from site-url by doing: Const tenant-domain = new URL(site-url).origin

This issue occurred for Outlook win 32, because MDO team started adding some, additional long query params to the share link. So, we are switching to use Method 1 instead of Method 2.

@jatgarg jatgarg self-assigned this Apr 21, 2024
@msfluid-bot
Copy link
Collaborator

@fluid-example/bundle-size-tests: +971 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 446.99 KB 446.99 KB No change
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 249.59 KB 249.59 KB No change
loader.js 128.15 KB 128.15 KB No change
map.js 41.36 KB 41.36 KB No change
matrix.js 143.7 KB 143.7 KB No change
odspDriver.js 97.2 KB 97.66 KB +477 Bytes
odspPrefetchSnapshot.js 41.87 KB 42.36 KB +494 Bytes
sharedString.js 161.71 KB 161.71 KB No change
sharedTree.js 329.75 KB 329.75 KB No change
Total Size 1.75 MB 1.75 MB +971 Bytes

Baseline commit: 90a4798

Generated by 🚫 dangerJS against 14867a6

@jatgarg jatgarg merged commit dc3f29c into microsoft:release/client/2.0.0-rc.2.0 Apr 22, 2024
27 checks passed
@jatgarg jatgarg deleted the rc2sh branch April 23, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants