Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data Virtualization]: Repro groupId and offline causing extra network calls #21910

Conversation

tyler-cai-microsoft
Copy link
Contributor

@tyler-cai-microsoft tyler-cai-microsoft commented Jul 16, 2024

AB#8937

This PR is expected to fail until the fix is merged in: #21908

The repro is:

  • Offline and Data virtualization are enabled
  • A virtualized datastore is created
  • It is summarized
  • A new container loads from that summary
  • In offline mode, we store the blobs on load that we have.
  • Because some of the blobs are not there, the loader makes a network call for each blob.

@github-actions github-actions bot added area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch labels Jul 16, 2024
@msfluid-bot
Copy link
Collaborator

@fluid-example/bundle-size-tests: +245 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 457.6 KB 457.63 KB +35 Bytes
azureClient.js 555.31 KB 555.35 KB +49 Bytes
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 258.68 KB 258.7 KB +14 Bytes
fluidFramework.js 391.57 KB 391.58 KB +14 Bytes
loader.js 134.02 KB 134.03 KB +14 Bytes
map.js 42.17 KB 42.18 KB +7 Bytes
matrix.js 145.68 KB 145.69 KB +7 Bytes
odspClient.js 523.12 KB 523.17 KB +49 Bytes
odspDriver.js 97.22 KB 97.24 KB +21 Bytes
odspPrefetchSnapshot.js 42.27 KB 42.29 KB +14 Bytes
sharedString.js 162.69 KB 162.7 KB +7 Bytes
sharedTree.js 382.08 KB 382.09 KB +7 Bytes
Total Size 3.27 MB 3.27 MB +245 Bytes

Baseline commit: 99bcf45

Generated by 🚫 dangerJS against d2f4b83

@tyler-cai-microsoft tyler-cai-microsoft merged commit 0bb9f76 into microsoft:main Jul 16, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants