Deduping code in Tiny-web-host/Gateway and support for spo urls in tiny-web-host. #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curtisman
reviewed
Oct 7, 2019
SamBroner
reviewed
Oct 7, 2019
jatgarg
changed the title
curtisman
reviewed
Oct 15, 2019
curtisman
reviewed
Oct 15, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.) Added Cnfigurable url resolver that takes in list of url resolvers and then loop through the resolvers to resolve the url.
2.) Make tiny-web-host and fluid-fetcher to start using the configurable url resolver.
3.) Dedup the code for url resolver in gateway and tiny webhost.
4.) Enabled the spo urls support in tiny-web-host(Able to load the scriptor in host).