Use URL instead of parse in container-loader utils #3145
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Standard |
vladsud
approved these changes
Aug 11, 2020
This was referenced Aug 13, 2020
|
This is not practical at present, closing out. Opened two linked issues to track the prerequisite work to make this change. |
Josmithr
pushed a commit
to Josmithr/FluidFramework
that referenced
this pull request
Aug 4, 2022
Convert the rushstack repo to a phased build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to solve the untyped parse problem I mentioned in #3142, and a good change anyway since the legacy URL API is deprecated and requires a polyfill.
Opening as a separate change since I think this one is less likely to require debate.