Update common-utils to ESLint 7 #3790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heliocliu
reviewed
Oct 6, 2020
common/lib/common-utils/.eslintrc.js
Outdated
| ], | ||
| "parserOptions": { | ||
| "project": [ "./tsconfig.json", "./test/tsconfig.json" ] | ||
| }, | ||
| "rules": { | ||
| "@typescript-eslint/no-non-null-assertion": "off", | ||
| "@typescript-eslint/no-unsafe-return": "off", | ||
| "@typescript-eslint/no-unused-vars": "off", |
There was a problem hiding this comment.
did these two warnings produce a lot of errors in common-utils/is there an issue to clean them up and remove these warning suppressions?
There was a problem hiding this comment.
@heliocliu Thanks - I'm not sure how I wound up suppressing these both at the project level. I fixed that. There aren't too many offenses. I tried to add typings for sha.js and change the import in hashFileNode.ts to import { sha1 } from "sha.js"; but that brings in node types which breaks the build.
If we had proper types for sha.js that would remove a couple of the unsafe returns.
heliocliu
approved these changes
Oct 7, 2020
This reverts commit 7d17c7c0c4b13d8b34bf46c99ea3307333a41687.
tylerbutler
force-pushed
the
eslint/common-utils
branch
from
5ed32f4
to
f8005c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.