Update server monorepo to ESLint 7 #3851
Conversation
|
Close and reopening to trigger the pipeline |
| public async send(messages: object[], tenantId: string, documentId: string): Promise<any> { | ||
| public async send(messages: Record<string, unknown>[], tenantId: string, documentId: string): Promise<any> { |
There was a problem hiding this comment.
Is this what typescript recommends now? Converting an object to Record<K, T> for better typing?
There was a problem hiding this comment.
Also this implements IProducer so I am wondering why TS is not complaining? Are objects and Record<string, unknown> interchangable?
There was a problem hiding this comment.
And there are more implementations of IProducer. So may be change them as well?
There was a problem hiding this comment.
This was a mistake. I experimented with some fixes and got sloppy about keeping them separate from the ESLint 7 upgrade itself. I'll remove these and replace with the disable comment. If we want to make this or a similar change we should do it separately from this PR.
There was a problem hiding this comment.
Resolved in an upcoming push.
tylerbutler
force-pushed
the
eslint/server
branch
from
8ba3d12
to
b17ce0d
Compare
tylerbutler
force-pushed
the
eslint/server
branch
from
098a887
to
f42e036
Compare
| @@ -16,7 +16,7 @@ export function validateTokenClaims( | |||
| documentId: string, | |||
| tenantId: string, | |||
| maxTokenLifetimeSec: number, | |||
| isTokenExpiryEnabled: boolean): ITokenClaims { | |||
| isTokenExpiryEnabled: boolean): ITokenClaims | undefined { | |||
There was a problem hiding this comment.
I don't understand how this compiled before...
No description provided.