-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experiment: Replace lerna/fluid-build with pnpm and lage #4593
Conversation
@christiango I noticed you're a contributor to lage so you might be interested in this. |
Thanks for the heads up! Some teams at Microsoft have recently moved from PNPM to Yarn, so it may be worth getting plugged into those conversations to get the full context. Office Online did this recently. That being said, lage should be a choice independent of your package manager choice. |
Very neat. What kind of perf improvements do you see? |
8cbc2ec
to
c6f5285
Compare
c6f5285
to
0b109ca
Compare
See PR #4804 for the yarn side of the experiment. Let's move most of the discussion there regarding comparing the two options.
I haven't done formal tests yet but it feels much faster, especially when updating dependencies or installing multiple clones. |
851f41c
to
8dfa8f0
Compare
8bbbaf5
to
57101ee
Compare
0155e67
to
b1775c3
Compare
This draft PR is an experiment of replacing our custom fluid-build tool and lerna with pnpm workspaces and lage.
I do not intend to check this in; I am sharing it in case anyone else is investigating speeding up our build system.
Goals of the experiment:
How to try it
npm i -g pnpm
.pnpm install
.pnpm run lage -- build
to run a build using lage.pnpm run tsc
.Note that the build will fail. Likely with an error like this:
That's the current state. I may work on it some more but feel free to take it and run if you're interested.