Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding server metadata to the client join message #4733

Merged
merged 1 commit into from
Jan 6, 2021

Conversation

GaryWilber
Copy link
Contributor

@GaryWilber GaryWilber commented Jan 6, 2021

Allow adding server metadata to the client join message.
This allows the frontend to pass additional information to deli / other lambdas when clients are joining

Copy link
Contributor

@tanviraumi tanviraumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are we planning to send in the metadata?

@GaryWilber
Copy link
Contributor Author

What are we planning to send in the metadata?

I'm testing sending the sequence number of the last initialMessage we send to the client when they connect. It could be used by a later lambda to send ops which they might not have received yet due to the delay between deli/broadcaster and when ops are added to storage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants