Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Event to MergeTree and Sequence on Local Segment Op Ack #5045

Merged
merged 8 commits into from
Feb 4, 2021

Conversation

anthony-murphy
Copy link
Contributor

Emit a new maintenance event, ACKNOWLEDGED when the op is round tripped from the server and the local segment is ack

@anthony-murphy
Copy link
Contributor Author

@montselozanod who i can't add as a reviewer for some reason

@anthony-murphy
Copy link
Contributor Author

/azp run Build - client packages

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@DLehenbauer
Copy link
Contributor

The failed test just needs to be taught to expect ACKNOWLEDGEMENT (-4) events. :-)

Change looks good.

@github-actions github-actions bot requested a review from vladsud February 4, 2021 19:46
@msfluid-bot
Copy link
Collaborator

@fluidframework/base-host: No change
Metric NameBaseline SizeCompare SizeSize Diff
main.js 169.41 KB 169.41 KB No change
Total Size 169.41 KB 169.41 KB No change
@fluid-example/bundle-size-tests: +332 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
container.js 193.96 KB 193.96 KB No change
map.js 45.92 KB 45.92 KB No change
matrix.js 144.44 KB 144.59 KB +155 Bytes
odspDriver.js 195.89 KB 195.89 KB No change
sharedString.js 158.48 KB 158.65 KB +177 Bytes
Total Size 738.69 KB 739.01 KB +332 Bytes

Baseline commit: 1329424

Generated by 🚫 dangerJS against 5b2be72

@anthony-murphy anthony-murphy merged commit 96aaec4 into microsoft:main Feb 4, 2021
anthony-murphy added a commit to anthony-murphy/FluidFramework-1 that referenced this pull request Feb 4, 2021
…t#5045)

Emit a new maintenance event, ACKNOWLEDGED when the op is round tripped from the server and the local segment is ack
anthony-murphy added a commit that referenced this pull request Feb 5, 2021
…5054)

Emit a new maintenance event, ACKNOWLEDGED when the op is round tripped from the server and the local segment is ack
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants