Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move GC state / functionality in container runtime into its own class #8134

Merged
merged 6 commits into from Nov 6, 2021
Merged

Move GC state / functionality in container runtime into its own class #8134

merged 6 commits into from Nov 6, 2021

Conversation

agarwal-navin
Copy link
Contributor

Fixes #8126.

The GC feature is growing and it is resulting in a lot of state and functionality in container runtime. Moving these into its own class so that it can be consolidated while leaving container runtime class more generic. This will also help in writing unit test for the GC functionality.

@agarwal-navin agarwal-navin requested a review from a team as a code owner November 4, 2021 22:27
@github-actions github-actions bot removed the request for review from a team November 4, 2021 22:28
@github-actions github-actions bot added area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc public api change Changes to a public API labels Nov 4, 2021
@agarwal-navin agarwal-navin changed the title Move GC state / functionality in container runtime to its own class Move GC state / functionality in container runtime into its own class Nov 4, 2021
@github-actions github-actions bot requested a review from vladsud November 5, 2021 17:53
@msfluid-bot
Copy link
Collaborator

msfluid-bot commented Nov 5, 2021 •
edited

⯅ @fluid-example/bundle-size-tests: +460 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
container.js 165.57 KB 166.02 KB ⯅ +460 Bytes
map.js 44.97 KB 44.97 KB ■ No change
matrix.js 142.6 KB 142.6 KB ■ No change
odspDriver.js 185.49 KB 185.49 KB ■ No change
odspPrefetchSnapshot.js 41.69 KB 41.69 KB ■ No change
sharedString.js 164.03 KB 164.03 KB ■ No change
Total Size 777.04 KB 777.49 KB ⯅ +460 Bytes

Baseline commit: 4279dd8

Generated by 🚫 dangerJS against d3c8077

@agarwal-navin agarwal-navin merged commit d00bc70 into microsoft:main Nov 6, 2021
@agarwal-navin agarwal-navin deleted the separateGCCLass branch November 11, 2021 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleath pleath pleath left review comments

@vladsud vladsud Awaiting requested review from vladsud

Assignees
No one assigned
Labels
area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc public api change Changes to a public API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move GC state and functionality in container runtime into its own class
4 participants
@agarwal-navin @msfluid-bot @pleath @vladsud