Cleanup some duplicate telemetry helpers #9016
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extractLogSafeErrorProperties
This helper existed in both telemetry-utils and common-utils packages. The copy in common-utils was out of date and unused in this repo, and has now been removed. Tests were moved to telemetry-utils and updated.
extractSafePropertiesFromMessage / extractLogSafeMessageProperties
extractLogSafeMessageProperties
was a non-exported copy (almost!) ofextractSafePropertiesFromMessage
. So I removed it and updated callers to use the shared one. The prop names added by the shared one are all prefixed withmessage
, but this was not the case for the duplicate. I will update #9014 with the changes in property names for the two impacted codepaths once this merges.