-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Summary telemetry cleanup #9021
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
my vs code is broken so running test here😑 |
⯅ @fluid-example/bundle-size-tests: +190 Bytes
Baseline commit: 6aa8639 |
packages/drivers/routerlicious-driver/src/shreddedSummaryDocumentStorageService.ts
Outdated
Show resolved
Hide resolved
packages/drivers/routerlicious-driver/src/wholeSummaryDocumentStorageService.ts
Outdated
Show resolved
Hide resolved
Can you also fix # 1 in this comment - #8965 (comment) |
I also see the following:
You could do them in a follow up PR if its too much :-). |
agarwal-navin
approved these changes
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: driver
Driver related issues
area: odsp-driver
area: runtime
Runtime related issues
area: tests
Tests to add, test infrastructure improvements, etc
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8965
referenceSequenceNumber
to fluid:telemetry:OdspDriver:uploadSummary_end eventPerformanceEvent
.uploadSummaryWithContext
event in odspGenerateSummary
eventSummarize_generate
, renamed "SummaryOp" toSummarize_Op
ackNackSequenceNumber
, added referenceSequenceNumbergenerateTelemetryProps
for bothsummarize_end
andsummarize_generate
events