Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summary telemetry cleanup #9021

Merged
merged 12 commits into from
Feb 12, 2022
Merged

Summary telemetry cleanup #9021

merged 12 commits into from
Feb 12, 2022

Conversation

chensixx
Copy link
Contributor

@chensixx chensixx commented Feb 4, 2022

Fixes #8965

  1. Added referenceSequenceNumber to fluid:telemetry:OdspDriver:uploadSummary_end event
  2. changed "GenerateSummary" event to call PerformanceEvent .
  3. removing uploadSummaryWithContext event in odsp
  4. adding fullTree, timeSinceLastAttempt, timeSinceLastSummary to GenerateSummary event
  5. renamed "GenerateSummary" event to Summarize_generate, renamed "SummaryOp" to Summarize_Op
  6. on summarize_end event, rename sequenceNumber to ackNackSequenceNumber, added referenceSequenceNumber
  7. using one variable generateTelemetryProps for both summarize_end and summarize_generate events

@github-actions github-actions bot added area: driver Driver related issues area: odsp-driver area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc labels Feb 4, 2022
@chensixx
Copy link
Contributor Author

chensixx commented Feb 4, 2022

my vs code is broken so running test here😑

@msfluid-bot
Copy link
Collaborator

msfluid-bot commented Feb 4, 2022

@fluid-example/bundle-size-tests: +190 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 384.73 KB 384.85 KB +122 Bytes
containerRuntime.js 185.3 KB 185.42 KB +122 Bytes
loader.js 158.62 KB 158.62 KB No change
map.js 50.64 KB 50.64 KB No change
matrix.js 145.46 KB 145.46 KB No change
odspDriver.js 194 KB 193.95 KB -54 Bytes
odspPrefetchSnapshot.js 45.37 KB 45.37 KB No change
sharedString.js 166.38 KB 166.38 KB No change
Total Size 1.33 MB 1.33 MB +190 Bytes

Baseline commit: 6aa8639

Generated by 🚫 dangerJS against baa2087

@chensixx chensixx marked this pull request as ready for review February 8, 2022 18:46
@chensixx chensixx requested review from a team as code owners February 8, 2022 18:46
@chensixx chensixx changed the title Summary Summary telemetry cleanup Feb 8, 2022
@agarwal-navin
Copy link
Contributor

Can you also fix # 1 in this comment - #8965 (comment)

@agarwal-navin
Copy link
Contributor

agarwal-navin commented Feb 8, 2022

I also see the following:

  • sequenceNumber does not exist on GenerateSummary (now Summarize_generate).
  • referenceSequenceNumber does not exist on Summarize_end.
    Can you please add these too.

You could do them in a follow up PR if its too much :-).

@chensixx chensixx merged commit cf85873 into microsoft:main Feb 12, 2022
@chensixx chensixx deleted the summary branch April 21, 2022 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: driver Driver related issues area: odsp-driver area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Summary telemetry cleanup to make data easier to analyze
3 participants