Rename telemetry prop #9045
Merged
Rename telemetry prop #9045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is initialized with common headers but used to tack on other stuff to log
On response telemetry props
github-actions
bot
added
area: definitions
area: driver
|
@abrahamrq FYI |
⯆ @fluid-example/bundle-size-tests: -228 Bytes
Baseline commit: bf1ff87 |
|
Feels like the "fix" should be on FFX side. I.e. nothing in the system prevents some layer using dashes, and that maybe fine for other systems. |
vladsud
reviewed
Feb 8, 2022
vladsud
approved these changes
Feb 8, 2022
heliocliu
pushed a commit
to heliocliu/FluidFramework-1
that referenced
this pull request
Feb 17, 2022
The office telemetry logging code doesn't like dashes in telemetry prop names. I thought I fixed this in microsoft#8449 but the fix was incomplete. That PR addressed the error case, but I didn't realize that for successful requests we were stashing the same telemetry prop on the internal response object and later logging it as well. So I fixed that, and renamed the property bag to be more clear that it's for logging and not for business logic.
heliocliu
pushed a commit
to heliocliu/FluidFramework-1
that referenced
this pull request
Feb 17, 2022
The office telemetry logging code doesn't like dashes in telemetry prop names. I thought I fixed this in microsoft#8449 but the fix was incomplete. That PR addressed the error case, but I didn't realize that for successful requests we were stashing the same telemetry prop on the internal response object and later logging it as well. So I fixed that, and renamed the property bag to be more clear that it's for logging and not for business logic.
heliocliu
added a commit
that referenced
this pull request
Feb 17, 2022
The office telemetry logging code doesn't like dashes in telemetry prop names. I thought I fixed this in #8449 but the fix was incomplete. That PR addressed the error case, but I didn't realize that for successful requests we were stashing the same telemetry prop on the internal response object and later logging it as well. So I fixed that, and renamed the property bag to be more clear that it's for logging and not for business logic. Co-authored-by: Mark Fields <markfields@users.noreply.github.com>
heliocliu
added a commit
that referenced
this pull request
Feb 17, 2022
* Rename telemetry prop (#9045) The office telemetry logging code doesn't like dashes in telemetry prop names. I thought I fixed this in #8449 but the fix was incomplete. That PR addressed the error case, but I didn't realize that for successful requests we were stashing the same telemetry prop on the internal response object and later logging it as well. So I fixed that, and renamed the property bag to be more clear that it's for logging and not for business logic. * undo content change Co-authored-by: Mark Fields <markfields@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The office telemetry logging code doesn't like dashes in telemetry prop names. I thought I fixed this in #8449 but the fix was incomplete. That PR addressed the error case, but I didn't realize that for successful requests we were stashing the same telemetry prop on the internal response object and later logging it as well.
So I fixed that, and renamed the property bag to be more clear that it's for logging and not for business logic.