Support NET Standard 2.0 #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengmu
reviewed
Mar 1, 2021
| @@ -48,7 +48,7 @@ public Task<int> GetCountAsync() | |||
| return Task.FromResult(2); | |||
| } | |||
|
|
|||
| public IDictionary<string, string> GetDictionary() | |||
| public Dictionary<string, string> GetDictionary() | |||
There was a problem hiding this comment.
Dictionary [](start = 15, length = 10)
just curious, why do you change from "IDictionary" ? #Closed
There was a problem hiding this comment.
Oh oops. I was testing something else before I started the csproj changes. I'll remove this.
In reply to: 584957321 [](ancestors = 584957321)
zhengmu
reviewed
Mar 1, 2021
| <Compile Include="src\SubroutineAction.cs" /> | ||
| <Compile Include="src\TreeNodeContext.cs" /> | ||
| <Compile Include="src\TreeWalkerParameters.cs" /> | ||
| <Compile Include="src\TreeWalkerSession.cs" /> |
There was a problem hiding this comment.
will the new SDK style auto include all .cs files? #Closed
There was a problem hiding this comment.
Yes! Most of the messy tags that used to be required are default behavior in the new csproj format.
In reply to: 584981315 [](ancestors = 584981315)
This was referenced Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ask and you shall receive! After several requests to add NET Standard support to Forge, I went down the rabbit hole and came out with hopefully a solution.