Feature/forceparallelactions #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure ForgeActions run in parallel (when part of the same TreeNode) by immediately yielding back the task in ExecuteActionWithRetry.
This prevents an issue where ForgeActions would not get kicked off in quick succession as expected, but only once the execution path in the ForgeAction performed an await. Issues were faced where ForgeActions would be running synchronously, and only kick off the "parallel action" after the first ForgeAction was fully completed.
Also fixed a flaky UT related to a race when cancelling the tree. Either a TaskCanceledException or OperationCanceledException will be thrown depending which task recognizes the cancelation token first.