Fix/implement C++2020 compilation, tests, and CI #1017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitrykobets-msft
force-pushed
the
dmitrykobets-msft/fix-span-2020
branch
from
d0b0eac
to
4430ba9
Compare
|
Out of curiosity, is there a specific issue that you're looking to fix with this? |
|
@SloppyJaconda It appears that the C++20 feature support actually had compilation / syntax errors. This was hidden because C++20 was never part of the CI pipeline, so the tests were never run. So this PR fixes those errors and attempts to enable C++20 in the CI |
dmitrykobets-msft
force-pushed
the
dmitrykobets-msft/fix-span-2020
branch
from
f7fc762
to
2d6167a
Compare
dmitrykobets-msft
force-pushed
the
dmitrykobets-msft/fix-span-2020
branch
24 times, most recently
from
6a657c0
to
b07cd48
Compare
dmitrykobets-msft
force-pushed
the
dmitrykobets-msft/fix-span-2020
branch
13 times, most recently
from
6ad2fa3
to
e3567c5
Compare
dmitrykobets-msft
changed the title
dmitrykobets-msft
force-pushed
the
dmitrykobets-msft/fix-span-2020
branch
10 times, most recently
from
7bfc115
to
f02afb1
Compare
dmitrykobets-msft
force-pushed
the
dmitrykobets-msft/fix-span-2020
branch
from
f02afb1
to
640cb1d
Compare
sunnychatterjee
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The C++2020 features (
std::spansupport) were not enabled in the CI. As a result, the code had compilation issues that were never caught. Furthermore, the compiler versions in the README did not match up to the compilers that were actually being tested. For instance, the minimum GCC version advertised is 8, but we are testing 7.5.0 instead. The precise versions we should be testing will be re-visited in a later PR. But for now, this PR simply updates the README to be accurate to what is currently being tested.Previously, the guard for the span tests was
__cplusplus >= 202002L. Unfortunately, this does not work for all compilers. For instance, inGCC 10, running with-std=c++20will fail the above condition (__cpluspluswill still be at 2017), and yet__cpp_lib_span >= 202002Lwill be true. But forGCC 9andGCC 8,__cpluspluswill still be at 2017 and__cpp_lib_spanis undefined (neither have<span>support). In all cases above, the span tests will be silently skipped.To avoid this confusing / incorrect (in the case of
GCC 10) behavior, make the span tests execute unconditionally if running in CI mode with C++20 enabled. If a compiler version does not support span, the C++20 version should be explicitly removed from its CI jobs.