solve span compile problem with gcc 5.5.0 #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @beinhaerter, thanks for the fix - I think it's fine to merge because it's so minimal and addresses a bug in GCC (albeit old). Can you rebase / merge on top of the latest main branch? I recently pushed some changes that should fix the failing CI_android run which is blocking the merge for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves a compile problem I encountered while using span on gcc 5.5.0. I know that platform is old but I have one embedded platform where I don't get a newer gcc. As this change does not break anything on newer gcc maybe it can just be merged?