Prevent inefficient copying when using not_null::get #1059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitrykobets-msft
changed the title
hsutter
approved these changes
Oct 11, 2022
|
LGTM, thanks Dmitry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #550 highlighted overhead in
not_null::getfor larger types such asshared_ptr. Every call togetwould return a copy of the contained value.This PR implements Herb's suggestion for changing the return type of
not_null::get. Thenot_null's value will now only be copied if it is "trivially copyable"; otherwise, it will be returned by const reference.Note: this change also forces the returned copy to be
const.