1070 compilation errors around string_span #1074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solves issue microsoft#1070 and removes the class `string_span`. The only content remaining in the header file `gsl/string_span` is the `*zstring` types. This also removes the `string_span_tests.cpp` unit tests as these were only for the deprecated `string_span` class.
|
Great, thanks! |
dmitrykobets-msft
added a commit
that referenced
this pull request
Jun 28, 2023
With `string_span` having been deprecated (#931, #945) and removed (#1074), the header `<gsl/string_span>` now only contains the definitions for the `zstring` family. Update the name accordingly from `<gsl/string_span>` to `<gsl/zstring>`. The old header is now deprecated and should no longer be used and will be removed in some future release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1070
This solves issue #1070 and removes the class
string_span. The only content remaining in the header filegsl/string_spanis the*zstringtypes.This also removes the
string_span_tests.cppunit tests as these were only for the deprecatedstring_spanclass.