Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inspect only __cpp_lib_byte, drop _HAS_STD_BYTE #1145

Merged
merged 1 commit into from Feb 26, 2024

Conversation

StephanTLavavej
Copy link
Member

Long-awaited followup to #822 which addressed #821.

GSL 4.0.0, released 2 years ago, dropped support for VS 2017. Only VS 2019 and VS 2022 are supported. Therefore, GSL can now always use the Standard feature-test macro __cpp_lib_byte to sense whether MSVC's STL provides std::byte. It should no longer inspect the non-Standard macro _HAS_STD_BYTE (which is our "control macro").

@d-winsor d-winsor merged commit 2e0d1ba into microsoft:main Feb 26, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants