Reworked span to match GSL design. #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilmacintosh
pushed a commit
that referenced
this pull request
Nov 30, 2015
Reworked span to match GSL design.
This was referenced Nov 30, 2015
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning: breaking changes!
This commit makes a number of changes to
spanto make it match the current GSL design (which I will publish soon to the CppCoreGuidelines repository). It also addresses a number of annoyances about the existing implementation (not usingnarrow_castwhere appropriate, for example). I also took this opportunity to run clang-format against span.h. Hopefully that makes it more consistent.string_span' will be dealt with separately soon.strided_span` is likely to be removed in the near future but lives on for now.