Fix issue #45: comparing two maybe_null_dbg's can cause fail_fast #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Squeezing another small change in here. |
trebconnell
force-pushed
the
fixmaybenull
branch
from
8778015
to
996aa06
Compare
|
Looks good, thanks trebconnell! |
neilmacintosh
pushed a commit
that referenced
this pull request
Sep 24, 2015
Fix issue #45: comparing two maybe_null_dbg's can cause fail_fast
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for maybe_null_dbg and fix bug where comparing two of them results in an implicit conversion to T, and a call to get().