Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow #include <gsl/...> without repeating gsl #725

Closed
wants to merge 1 commit into from

Conversation

kivadiu
Copy link

@kivadiu kivadiu commented Aug 22, 2018

Headers are named inconsistently: algorithm, assert, byte and util
headers are prefixed with gsl_. This is to avoid name clash with
standard headers for people including directly from the gsl directory.

However, for people including from the parent directory of gsl, in
addition to looking inconsistent, this also looks redundant:
#include <gsl/gsl_assert>

This adds algorithm, assert, byte and util headers that just forward to
gsl_ headers. It is then possible to include like this:
#include <gsl/assert>

Fixes #71

Headers are named inconsistently: algorithm, assert, byte and util
headers are prefixed with gsl_. This is to avoid name clash with
standard headers for people including directly from the gsl directory.

However, for people including from the parent directory of gsl, in
addition to looking inconsistent, this also looks redundant:
#include <gsl/gsl_assert>

This adds algorithm, assert, byte and util headers that just forward to
gsl_ headers. It is then possible to include like this:
#include <gsl/assert>

Fixes microsoft#71
@msftclas
Copy link

msftclas commented Aug 22, 2018

CLA assistant check
All CLA requirements met.

@JordanMaples
Copy link
Contributor

Maintainer's call: We see your point about the inconsistently named headers. We agree this is... unfortunate. If we were to fix it, we'd probably do it similarly to how you suggest. However, we don't think it's worth the effort of creating additional headers at this time, it could cause confusion for newcomers to see a lot of headers that are duplicates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Template specialization for ArrayViewTypeTraits uses incorrect static member of is_reference
3 participants