Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace classic bindings with compiled bindings in UWP app #1

Merged
merged 1 commit into from Jan 5, 2016

Conversation

alinapopa
Copy link
Contributor

Replace classic bindings with compiled bindings in UWP app.

@msftclas
Copy link

Hi @alinapopa, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Alina Popa). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@@ -11,6 +12,8 @@
<ResourceDictionary.MergedDictionaries>
<ResourceDictionary Source="/Styles/Styles.xaml"/>
<ResourceDictionary Source="/Styles/Colors.xaml"/>
<ResourceDictionary Source="ms-appx:///Styles/DataTemplates.xaml"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this referenced differently than the previous two styles?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

alinapopa pushed a commit that referenced this pull request Jan 5, 2016
Replace classic bindings with compiled bindings in UWP app
@alinapopa alinapopa merged commit e5170d0 into microsoft:master Jan 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants